Fix: option forceclose removed in latest haproxy #9188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an alias for `option httpclose` See https://cbonte.github.io/haproxy-dconv/1.9/configuration.html#4.2-option%20forceclose
cdrini
added
Priority: 0
|
Auto-merging since blocks deploys, and its a tiny change. Didn't create an issue for the same reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an alias for
option httpclose, which we specify a few lines up.See https://cbonte.github.io/haproxy-dconv/1.9/configuration.html#4.2-option%20forceclose
See also: https://github.com/internetarchive/olsystem/pull/209
Technical
Testing
Patch deployed to fix haproxy not starting up due to the now invalid option.
Screenshot
Stakeholders