Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some i18n-related bugs #9195

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Apr 30, 2024

Addendum to:

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 30, 2024
Copy link
Contributor

@merwhite11 merwhite11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is displaying properly now ! Good catch :)
Screenshot 2024-04-30 at 10 02 03 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdrini
I'm assuming the fact that the word 'from' is still showing up in English is because the translators haven't translated this in a .po file yet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Exactly 👍

@cdrini cdrini merged commit 2addb70 into internetarchive:master Apr 30, 2024
3 checks passed
@cdrini cdrini deleted the hotfix/i18n-string branch April 30, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants