Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n syntax in Donate Modal to include closing tags #9298

Conversation

rebecca-shoptaw
Copy link
Collaborator

Closes #9297.

Hotfix. Fixes the last two remaining un-closed tags in our messages.pot file, both of which are located in DonateModal.html.

Technical

  • Simply changed the placement of the closing quote and parentheses for the relevant strings
  • Also searched the messages.pot file for various HTML opening tags (<a, <i>, <em>, <strong>) and confirmed that, aside from these two, each other opening tag was accompanied by a closing tag

Testing

  1. Go the Donate Modal section of the messages.pot file
  2. Confirm all opening tags are now closed

Screenshot

Stakeholders

@dcapillae

Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scottbarnes scottbarnes merged commit 6772179 into internetarchive:master May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick i18n cleanup to include closing tags
2 participants