Update JS build dependencies #9410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove: - @babel/plugin-syntax-dynamic-import: No longer needed since babel 7.8.0 - @babel/register: Not referenced anywhere
cdrini
added
the
On testing.openlibrary.org
|
@cdrini I have gone through the site a good bit on testing but haven't see any new console errors or issues when editing books/authors/profiles or using bookreader. vue-loader v17:
css-loader v7 and v6 have breaking changes but none of them seem particularly likely to be effecting our project. less-loader v7 -> v12. changelog here
style-loader changelog
|
|
Awesome sleuthing, than you @RayBB !! That seems good to me; I also did some QA'ing around things seemed to be ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #2340 . Also updates some dependencies needed for #7547 .
Also remove:
Technical
Testing
Website worked as before on FF, IE11 (using as a metre stick to test all our JS build/bundling/transpiling is working)
Screenshot
Stakeholders
@RayBB