Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reported low water mark on empty newsgroups #250

Closed
Julien-Elie opened this issue Jan 5, 2023 · 0 comments
Closed

Fix reported low water mark on empty newsgroups #250

Julien-Elie opened this issue Jan 5, 2023 · 0 comments
Assignees
Labels
bug Something isn't working C: nnrpd Related to nnrpd P: medium Medium priority RFC compliance Related to NNTP standards and the format of Usenet articles
Milestone

Comments

@Julien-Elie
Copy link
Contributor

When the highest used article number of an empty newsgroup is n, INN currently reports low=n+1, high=n.
We should instead report low=n, high=n-1 in accordance with RFC 3977 which recommends that the high water mark is one less than the low water mark.

Besides, the reported low water mark currently exceeds 2^31-1 with that rule:

GROUP trigofacile.test.maxartnum
211 0 2147483648 2147483647 trigofacile.test.maxartnum

This should be fixed, and make sure that the reported high water mark cannot be negative.

@Julien-Elie Julien-Elie added bug Something isn't working C: nnrpd Related to nnrpd P: medium Medium priority RFC compliance Related to NNTP standards and the format of Usenet articles labels Jan 5, 2023
@Julien-Elie Julien-Elie added this to the 2.7.1 milestone Jan 5, 2023
@Julien-Elie Julien-Elie self-assigned this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C: nnrpd Related to nnrpd P: medium Medium priority RFC compliance Related to NNTP standards and the format of Usenet articles
Development

No branches or pull requests

1 participant