Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inncheck error #268

Closed
nelgin opened this issue May 9, 2023 · 3 comments
Closed

inncheck error #268

nelgin opened this issue May 9, 2023 · 3 comments
Assignees
@Julien-Elie
Labels
bug Something isn't working C: utilities Related to utilities P: low Low priority
Milestone
2.7.2

Comments

@nelgin
Copy link

nelgin commented May 9, 2023

Using the recommended parameters per the man page

news@www:~/bin$ inncheck -a --perm --pedantic

Results in the following error.

Use of uninitialized value $k in hash element at /news/bin/inncheck line 834, <$IN> line 325.
/news/etc/newsfeeds:319: unknown flag `'
@Julien-Elie
Copy link
Contributor

This Perl warning should be fixed, indeed.
Could you please tell what the newsfeeds entry is at line 319? (empty flags?)

@nelgin
Copy link
Author

nelgin commented May 9, 2023 via email •
edited by Julien-Elie
Loading

@Julien-Elie
Copy link
Contributor

Fixed. There's no longer a Perl warning for an undefined variable. And the reported error will now be:

/news/etc/newsfeeds:319: empty flag in `Ap,Tm,,<262144'

It will be easier to understand what is wrong.

@Julien-Elie Julien-Elie self-assigned this May 15, 2023
@Julien-Elie Julien-Elie added bug Something isn't working C: utilities Related to utilities P: low Low priority labels May 15, 2023
@Julien-Elie Julien-Elie added this to the 2.7.2 milestone May 15, 2023
Julien-Elie added a commit that referenced this issue Jul 8, 2023
@Julien-Elie
inncheck: Correctly parse empty newsfeeds flags
d8868b4 
"Ap,Tm,,<262144" produced a Perl warning and an error of unknown flag.

inncheck now reports an empty flag.

Thanks to Nigel Reed for the bug report.

close #268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julien-Elie Julien-Elie

Labels
bug Something isn't working C: utilities Related to utilities P: low Low priority
Milestone
2.7.2
Development

No branches or pull requests
2 participants
@nelgin @Julien-Elie