We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When setting show_only_changes=true, visualize_as_dataframe still appears to show all data, as the precision seems to be changing.
Would suggest there should be a fuzz factor in the comparison for display to avoid the FP comparison pitfalls.
AIUI, CounterfactualExamples uses the following:
if newli[ix][jx] == org[jx]:
Which introduces float comparison issues (i.e. in some cases, nothing with equate due to minor fluctuations, even if seemingly unchanged).
This should be using math.isclose with a factor of org[ix]/1000000 or similar.
math.isclose
org[ix]/1000000
The text was updated successfully, but these errors were encountered:
No branches or pull requests
When setting show_only_changes=true, visualize_as_dataframe still appears to show all data, as the precision seems to be changing.
Would suggest there should be a fuzz factor in the comparison for display to avoid the FP comparison pitfalls.
AIUI, CounterfactualExamples uses the following:
if newli[ix][jx] == org[jx]:
Which introduces float comparison issues (i.e. in some cases, nothing with equate due to minor fluctuations, even if seemingly unchanged).
This should be using
math.isclose
with a factor oforg[ix]/1000000
or similar.The text was updated successfully, but these errors were encountered: