Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Search is cached in PWA and does not trigger a new REST call #1024

Merged
merged 2 commits into from Feb 23, 2022

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented Feb 22, 2022

… state is stored

PR Type

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Once a product search is successfully done the result is added to the State Management. In a later search for the same search term the result is taken from the State Management (this is okay for fast result rendering) but no REST request is triggered to update this result information. This should be done for search results.

Issue Number: Closes #983

What Is the New Behavior?

Every product search triggers a REST call that fetches and updates any search result information the State Management might already have.

Does this PR Introduce a Breaking Change?

[ ] Yes
[ x ] No

Other Information

AB#74515

@Eisie96 Eisie96 changed the title refactor: product listing calls will be executed although the current… Product Search is cached in PWA and does not trigger a new REST call Feb 22, 2022
@MaxKless MaxKless self-assigned this Feb 22, 2022
@Eisie96 Eisie96 merged commit 9326be7 into develop Feb 23, 2022
@Eisie96 Eisie96 deleted the refactor/cached-product-search branch February 23, 2022 12:47
shauke pushed a commit that referenced this pull request Feb 23, 2022
…call (#983, #1024)

* product listing actions will always trigger new REST-Requests
@shauke shauke added this to the 2.1 milestone Feb 23, 2022
SGrueber pushed a commit that referenced this pull request May 19, 2022
…call (#983, #1024)

* product listing actions will always trigger new REST-Requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Search is cached in PWA and does not trigger a new REST call
3 participants