refactor: move localization keep patterns where they are needed #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/remove-unused-translations-keys
branch
2 times, most recently
from
b73b04a
to
ecaf713
Compare
dhhyi
force-pushed
the
refactor/remove-unused-translations-keys
branch
from
ecaf713
to
6fcd8a4
Compare
|
|
The pattern /^subject.*/i is needed because in ICM versions lower than 7.10.38 the cost center admin is not allowed to read the list of users for the customer. In this case the translation key 'subject.has.no.permission.assigned' is used to show a corresponding error message on the cost center user assignment page. But the regular expression could be more specific |
So we can do it like this? 8f71726 |
shauke
pushed a commit
that referenced
this pull request
Mar 3, 2022
shauke
added a commit
that referenced
this pull request
Mar 3, 2022
shauke
force-pushed
the
refactor/remove-unused-translations-keys
branch
from
6ca00fd
to
3b9b6d6
Compare
shauke
force-pushed
the
refactor/remove-unused-translations-keys
branch
from
3b9b6d6
to
b8a340b
Compare
shauke
approved these changes
Mar 4, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
Localization keep patterns are managed in the cleanup script.
What Is the New Behavior?
Localization keep patterns are managed where they are defined. (with an annotation)
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Hi @SGrueber @suschneider @MaxKless 😃
I think the
.error.keep pattern in thescripts/clean-up-localizations.jsis outdated. I see that all of the error feedback regarding payments comes from the API, there should be no need to keep those translation keys in the PWA (also because we now fetch specific keys directly from the ICM). Regarding anything not payment related? I'm not sure...Please check if my assumption is correct.
In projects every uselessly translated localization is money 🤑
AB#72086