feat: Remove quote requests from cart #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
requested changes
Feb 28, 2022
...p/extensions/quoting/shared/quoting-basket-line-items/quoting-basket-line-items.component.ts
Outdated
Show resolved
Hide resolved
...extensions/quoting/shared/quoting-basket-line-items/quoting-basket-line-items.component.html
Outdated
Show resolved
Hide resolved
added 4 commits
February 28, 2022 14:35
dhhyi
previously approved these changes
Mar 2, 2022
SGrueber
approved these changes
Mar 4, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Luis Garcia <luis.miguel.garcia@evident.nl> Co-authored-by: Danilo Hoffmann <dhhyi@aol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Closes #948
Quote products cannot be removed from the cart once they have been added to it.
What Is the New Behavior?
Quote products can now be removed from the cart.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x] No
ToDo
[ ] Unit tests
[ ] Add localization key 'quote.basket_items.label' for all languages (now is only for US)