Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve module.xml format on disk upon import to .ZPM document stream #501

Closed
isc-tleavitt opened this issue Jun 10, 2024 · 1 comment
Closed

Preserve module.xml format on disk upon import to .ZPM document stream #501

isc-tleavitt opened this issue Jun 10, 2024 · 1 comment
Assignees
@isc-shuliu
Labels
bug Something isn't working usability

Comments

@isc-tleavitt
Copy link
Contributor

We need to preserve the format of module.xml on disk when it is imported to the .ZPM document stream, such that the .ZPM document can be edited server-side effectively with embedded source control.
@isc-tleavitt isc-tleavitt added the bug Something isn't working label Jun 10, 2024
@isc-tleavitt isc-tleavitt mentioned this issue Jun 10, 2024
Open
@isc-tleavitt isc-tleavitt mentioned this issue Jun 24, 2024
Open
@isc-shuliu
Copy link
Collaborator

isc-shuliu commented Oct 2, 2024 •
edited
Loading

@isc-tleavitt

ipm/src/cls/IPM/StudioDocument/Module.cls

Line 105 in 4a07448

Do tReader.Next(.tModule,.tSC)

Is the intention here to use pModule (the output argument) instead of tModule?

@isc-shuliu isc-shuliu mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isc-shuliu isc-shuliu

Labels
bug Something isn't working usability
Projects
v1.0 targets
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isc-tleavitt @isc-shuliu