-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A floating window for suggestions? #7
Comments
I have been thinking about the same thing. Will probably give it a try after 0.5.0. |
Great idea |
I've read the latest release notes and would welcome a floating window with suggestions. Personally, I would suggest placing the window below the current text cursor, similar to Xcode's own suggestions. As an alternative, if that would interfere too much with Xcode's own suggestions, to the bottom left or above the cursor could also be options. |
@MrMage exactly! Similar to that of Grammarly Mac |
@imWildCat do you have a screenshot of that overlay for illustration? :-) |
Great idea referencing the Grammarly pop up. That would work here for sure! +1. Note: I know sometimes the suggestions are quite large, unlike what's suggested in Grammarly but I don't think that's a problem as it's either filling up space on the page under the box or contained in a clean separate box which can be accepted/rejected. |
I think I'll try the Grammarly-like solution first, as it appears easier to implement to me. If we still want the below-cursor solution later, it shouldn't be too hard to make the switch, since the only difference is where the window is located. |
Thanks man! I believe even any floating window that is draggable is good! No need to be perfect at the initial stage. Feel free to split tasks or create GH items for known issues and ask the community to fix. |
The first version is released in 0.8.1! During development, I found that it's difficult to implement a suggestion window that follows the text cursor. The biggest problem is that we don't have a way to listen to the appearance and disappearance of Xcode's built-in completion panel. If we want to avoid overlapping with it, we would have to place the suggestion window in a strange position. Therefore, I think the current solution is better. |
Wow how cool! Looks fantastic - looking forward to using it this week!! |
@intitni this is huge! Thank you! |
I had a similar need for my plugin embedding NeoVim in Xcode. I found a workaround by:
Hope that helps, thank you for your work on this plugin! |
Based on my observation, the |
No I get the destroyed event, otherwise that would break some keys in ShadowVim. Both when accepting a completion item or using escape. I've tested only on Xcode 14.2 though. |
Oh, and I added the |
Awesome update with floating window! It gave me a second chance to use Copilot! thanks) |
This issue is stale because it has been open for 30 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Instead of adding contents in the editor for suggestions, could we use a macOS window for suggestions?
Code in the editor seems to be super disturbing.
The text was updated successfully, but these errors were encountered: