Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency json5 to v2.2.2 [security] #224

Merged
merged 1 commit into from
May 7, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 16, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
json5 (source) 2.2.0 -> 2.2.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2022-46175

The parse method of the JSON5 library before and including version 2.2.1 does not restrict parsing of keys named __proto__, allowing specially crafted strings to pollute the prototype of the resulting object.

This vulnerability pollutes the prototype of the object returned by JSON5.parse and not the global Object prototype, which is the commonly understood definition of Prototype Pollution. However, polluting the prototype of a single object can have significant security impact for an application if the object is later used in trusted operations.

Impact

This vulnerability could allow an attacker to set arbitrary and unexpected keys on the object returned from JSON5.parse. The actual impact will depend on how applications utilize the returned object and how they filter unwanted keys, but could include denial of service, cross-site scripting, elevation of privilege, and in extreme cases, remote code execution.

Mitigation

This vulnerability is patched in json5 v2.2.2 and later. A patch has also been backported for json5 v1 in versions v1.0.2 and later.

Details

Suppose a developer wants to allow users and admins to perform some risky operation, but they want to restrict what non-admins can do. To accomplish this, they accept a JSON blob from the user, parse it using JSON5.parse, confirm that the provided data does not set some sensitive keys, and then performs the risky operation using the validated data:

const JSON5 = require('json5');

const doSomethingDangerous = (props) => {
  if (props.isAdmin) {
    console.log('Doing dangerous thing as admin.');
  } else {
    console.log('Doing dangerous thing as user.');
  }
};

const secCheckKeysSet = (obj, searchKeys) => {
  let searchKeyFound = false;
  Object.keys(obj).forEach((key) => {
    if (searchKeys.indexOf(key) > -1) {
      searchKeyFound = true;
    }
  });
  return searchKeyFound;
};

const props = JSON5.parse('{"foo": "bar"}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props); // "Doing dangerous thing as user."
} else {
  throw new Error('Forbidden...');
}

If the user attempts to set the isAdmin key, their request will be rejected:

const props = JSON5.parse('{"foo": "bar", "isAdmin": true}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props);
} else {
  throw new Error('Forbidden...'); // Error: Forbidden...
}

However, users can instead set the __proto__ key to {"isAdmin": true}. JSON5 will parse this key and will set the isAdmin key on the prototype of the returned object, allowing the user to bypass the security check and run their request as an admin:

const props = JSON5.parse('{"foo": "bar", "__proto__": {"isAdmin": true}}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props); // "Doing dangerous thing as admin."
} else {
  throw new Error('Forbidden...');
}

Release Notes

json5/json5 (json5)

v2.2.2

Compare Source

  • Fix: Properties with the name __proto__ are added to objects and arrays.
    ([#​199]) This also fixes a prototype pollution vulnerability reported by
    Jonathan Gregson! ([#​295]).

v2.2.1

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Dependency Dependencies fixes label Mar 16, 2023
@renovate renovate bot force-pushed the renovate/npm-json5-vulnerability branch from c8cdbcb to 9afdcfd Compare March 24, 2023 17:51
@renovate renovate bot force-pushed the renovate/npm-json5-vulnerability branch from 9afdcfd to 55bc07b Compare March 24, 2023 17:52
@renovate renovate bot changed the title fix(deps): update dependency json5 to v2.2.2 [security] fix(deps): update dependency json5 to v2.2.2 [security] - autoclosed Apr 21, 2023
@renovate renovate bot closed this Apr 21, 2023
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch April 21, 2023 03:49
@renovate renovate bot changed the title fix(deps): update dependency json5 to v2.2.2 [security] - autoclosed fix(deps): update dependency json5 to v2.2.2 [security] Apr 21, 2023
@renovate renovate bot reopened this Apr 21, 2023
@renovate renovate bot restored the renovate/npm-json5-vulnerability branch April 21, 2023 08:29
@renovate renovate bot merged commit 12a82c9 into v1.x May 7, 2024
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch May 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependency Dependencies fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants