Bunch of changes and refinements #69
Conversation
|
Ah, also. I couldn't run tests on macruby. So can't be sure I didn't screw up the nsjsonserialization. Need to check this. |
|
These changes look good… Would you mind rebasing from master so this will merge cleanly? I suspect you'll hit a few conflicts, since I recently touched some of the same code to get JRuby specs running/passing on Travis CI. |
We trust it's tested already.
|
Yep, doing that at the moment :) |
Cleaner syntax. Also, it's now possible to include MultiJson into other classes for whatever reason.
|
Looks like there are some date format issues on Ruby 1.8.7. |
|
@sferik what do you think, shoud I just remove this spec or make it respect weird 1.8 time format? |
|
Added a case for 1.8 time format. |
|
Hmmm. Do you think it's okay to have different results in Ruby 1.8 and Ruby 1.9? I think this could be problematic. |
|
I'm not sure if it's ok or not. At the same time I don't see any easy way to make it use consistent format. Also, pretty much all JSON gems code |
|
It looks like your patch fails on JRuby. It's not obvious to me what the issue is. Can you please investigate? I don't want to merge in code that breaks the build. It may be helpful to ask in the #jruby IRC channel on Freenode. |
|
Will do. |
|
The problems is Time test I've introduced here: rwz@d692b8e If you comment it, jruby passes the specs just fine. Weird. |
|
Strange indeed. I'd recommend asking the folks in #jruby about that. I think they could point you in the right direction. Or at least file a bug. |
|
a comment from @headius |
|
Should be all-green now. Travis just decided to reboot servers during latest build :( |
|
I had a feeling he might say that. 😦 |
|
This looks beautiful! Thanks again for your work on this. 🍻 |
Bunch of changes and refinements
|
These changes will help me resolve karmi/retire#510 in the tire gem. Any idea when this might be released? |
|
I'd like to get #71 merged in before I ship 1.6.0. |
I've just decided to put everything into a single pull-request.
I can split this into multiple pull-requests if you wish.