Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows passing extra headers to the Client Credentials strategy #257

Conversation

nikz
Copy link
Contributor

@nikz nikz commented Jun 20, 2016

Hiya,

This fixes (what I think) is a wee bug with the client_credentials grant where it won't allow passing through extra headers to the token request.

It includes a passing spec, although I'll be the first to admit it's a little hacky... any guidance there appreciated.

I also didn't add any documentation since it's a bugfix, and there's language to that effect under Authorization Grants but happy to do that if you'd like.

Cheers!

Nik

@coveralls
Copy link

coveralls commented Jun 20, 2016

Coverage Status

Coverage increased (+0.03%) to 96.591% when pulling a66534f on nikz:allow-passing-extra-headers-to-client-credentials into 7691a2c on intridea:master.

@thedarkside
Copy link

I ran into the same issue. It is a bug!

@djberg96
Copy link

Seems like this ought to be merged. The failures appear to be JRuby and/or Ruby 1.9.x or earlier only.

@josephpage josephpage added the bug label Jan 8, 2018
@josephpage
Copy link
Member

Hey @nikz,
The gem now has a new team of maintainers. 🎉
I'll be happy to merge your PR when the conflits will be resolved.

@josephpage josephpage self-assigned this Jan 8, 2018
@nikz
Copy link
Contributor Author

nikz commented Jan 8, 2018

@josephpage Great! I thought I made the change just now, but it seems Github isn't happy with it so I might have to do it properly instead - give me some time and I'll get it fixed up for you.

@pboling
Copy link
Member

pboling commented Jan 8, 2018

You will need to rebase on latest master in order to resolve the conflicts.

@josephpage josephpage added this to the 1.5.0 milestone Jan 9, 2018
@nikz
Copy link
Contributor Author

nikz commented Jan 27, 2018

@pboling @josephpage I actually think this has been fixed by this change. We could include the spec to verify it doesn't break again if you'd like (happy to adjust the PR), or feel free to close this PR.

Thanks!

@pboling
Copy link
Member

pboling commented Jan 29, 2018

@nikz Yes, great idea. More specs is great! I will extract the spec and merge it, unless a wild PR appears before I get to it. ;)

nikz added a commit to nikz/oauth2 that referenced this pull request May 5, 2018
This is a regression spec, based on the issue in oauth-xx#257 which
looks like it was fixed during a refactoring.
@nikz
Copy link
Contributor Author

nikz commented May 5, 2018

@pboling sent up #381 for you, so I'll close this one up now. Cheers!

@nikz nikz closed this May 5, 2018
@pboling pboling removed this from the 2.0.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants