New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows passing extra headers to the Client Credentials strategy #257
Allows passing extra headers to the Client Credentials strategy #257
Conversation
I ran into the same issue. It is a bug! |
Seems like this ought to be merged. The failures appear to be JRuby and/or Ruby 1.9.x or earlier only. |
Hey @nikz, |
@josephpage Great! I thought I made the change just now, but it seems Github isn't happy with it so I might have to do it properly instead - give me some time and I'll get it fixed up for you. |
You will need to rebase on latest master in order to resolve the conflicts. |
@pboling @josephpage I actually think this has been fixed by this change. We could include the spec to verify it doesn't break again if you'd like (happy to adjust the PR), or feel free to close this PR. Thanks! |
@nikz Yes, great idea. More specs is great! I will extract the spec and merge it, unless a wild PR appears before I get to it. ;) |
This is a regression spec, based on the issue in oauth-xx#257 which looks like it was fixed during a refactoring.
Hiya,
This fixes (what I think) is a wee bug with the
client_credentials
grant where it won't allow passing through extra headers to the token request.It includes a passing spec, although I'll be the first to admit it's a little hacky... any guidance there appreciated.
I also didn't add any documentation since it's a bugfix, and there's language to that effect under Authorization Grants but happy to do that if you'd like.
Cheers!
Nik