Fix rubocop update changes #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
cpetschnig
force-pushed
the
fix_rubocop_update_changes
branch
from
f2cd507
to
b61b4e4
Compare
added 2 commits
April 4, 2017 09:36
Since the Rubocop release 0.48 the code style checks no longer pass. This PR was created basically by running `rubocop -a` and `rubocop --auto-gen-config`.
cpetschnig
force-pushed
the
fix_rubocop_update_changes
branch
from
b61b4e4
to
06b5fb0
Compare
1 similar comment
|
Fixed with bfe3a43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Rubocop release 0.48 the code style checks no longer pass on Travis
This PR was created basically by running
$ rubocop -aand$ rubocop --auto-gen-config.The rule for
Style/MixinGroupinglooks like it's buggy. There are already some PRs to fix it (rubocop/rubocop#4177, rubocop/rubocop#4176), but I thought it would be best to exclude it via the todo-file. Maybe this file can be removed once Rubocop 0.48.1 is released.Also fixed some typos.