Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set basic_auth as default #312

Merged
merged 2 commits into from Jan 3, 2018
Merged

Set basic_auth as default #312

merged 2 commits into from Jan 3, 2018

Conversation

tetsuya
Copy link
Contributor

@tetsuya tetsuya commented Jun 28, 2017

This PR fixes #285 by setting :basic_auth as default for :auth_scheme

@coveralls
Copy link

coveralls commented Jun 28, 2017

Coverage Status

Coverage decreased (-0.3%) to 95.714% when pulling 7130ea9 on tetsuya:feature/basic_auth-as-default into 452a085 on intridea:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.714% when pulling 7130ea9 on tetsuya:feature/basic_auth-as-default into 452a085 on intridea:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.714% when pulling 7130ea9 on tetsuya:feature/basic_auth-as-default into 452a085 on intridea:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.714% when pulling 7130ea9 on tetsuya:feature/basic_auth-as-default into 452a085 on intridea:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.714% when pulling 7130ea9 on tetsuya:feature/basic_auth-as-default into 452a085 on intridea:master.

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage remained the same at 96.0% when pulling 93d11bc on tetsuya:feature/basic_auth-as-default into 452a085 on intridea:master.

@djberg96
Copy link

👍

@pboling pboling merged commit 0d71920 into oauth-xx:master Jan 3, 2018
@tetsuya tetsuya deleted the feature/basic_auth-as-default branch January 4, 2018 08:36
@josephpage josephpage added this to the 1.5.0 milestone Jan 9, 2018
niels added a commit to herimedia/omniauth-facebook that referenced this pull request Jan 23, 2018
As oauth2 is changing their default, which would break this gem.

See oauth-xx/oauth2#312.
@jhmoore
Copy link

jhmoore commented Mar 2, 2018

FWIW, this was a breaking change for us. Was this intended to be a breaking change?

@pboling
Copy link
Member

pboling commented Mar 2, 2018

@jhmoore The upcoming release, 1.5.0 2.0.0 (following SemVer 2.0), will have breaking changes. We are working on getting everything documented and prepared for a release as soon as possible. The fix should be just adding a bit of config, as here: simi/omniauth-facebook#291

@xtagon
Copy link

xtagon commented Mar 3, 2018

@pboling In that case should we call it 2.0.0 based on SemVer's requirement of bumping the major version for breaking changes? https://github.com/oauth-xx/oauth2/issues/262

@pboling
Copy link
Member

pboling commented Mar 3, 2018

@xtagon excellent point, and absolutely. We have backwards incompatible changes and we need to thoroughly document them and align the next release version number accordingly. Looks like 2.0.0 it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in Changelog Has been added to Changelog
Projects
None yet
7 participants