-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RxCocoa/Swift/DataSource/Gesture #243
Conversation
@MatrixSenpai Awesome, we will take a look at it. Also, it seems that the CI build failed... |
@MatrixSenpai looks it's failing for below case
|
Ah yes. edit @badrinathvm: it had nothing to do with a test case, the example project failed compilation |
thank you @MatrixSenpai for fixing it. Looks good to me. |
Can we get one more approval and merge? I'd love to be able to use this library |
Is it possible for someone to look at this pull request? It would be very much appreciated as I'd also love to use this library. @MatrixSenpai Thanks for making this change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @MatrixSenpai!
Hey @MatrixSenpai !! Thank you for pushing the required changes here. We are also kind of blocked on the same thing, can we merge these changes since it seemed to be approved? |
used this framework recently in my project and love everything in this framework, except been blocked by the same issue here. Can we please merge this pull request? thanks |
for those who still struggle with this issue. What I did maybe silly but effective, I grab the source code folder and manually import into my project , of course, I had to put import... in every single file, then using pod RxCocoa to update the cocoa version. |
Alternative approach is to use like below in your pod files until this gets merged
|
I tried that but unfortunately my pod update couldnt' find the branch. Also tried on commit but no success. Any other suggestions that might help? Appreciate your time and original suggestion! |
Apologies - I got it working using just a little tweak. I pointed the git repo to MatrixSenpai's fork like so, Thanks, this has unblocked me till the merge goes ahead. Much appreciated. |
I am sorry about the delay on this PR... we have a lot of internal applications consuming this and we need to ensure everyone is ready for the upgrade. It shouldn't be long. |
@croossin I think we are ready to take this in Mint too. |
This has been merged and released in version 3.0.0. |
…rkmode * 'master' of github.com:FireHawkDigital/CardParts: (23 commits) spacing formatting in podspec Bumping version to 3.1.3 Update CardPartHistogramView.swift Bmping version to 3.1.2 Fix wrong layout on iPad modal presentation Update CardParts.podspec Update CardPartHistogramView.swift (intuit#253) Bump podspec (intuit#251) Adding dynamic support of height in CardPartPagedView (intuit#244) Bump podspec (intuit#250) Update RxCocoa/Swift/DataSource/Gesture (intuit#243) Update CardParts.podspec (intuit#241) Card Parts Bottom Sheet View Controller (intuit#240) Update CardParts.podspec (intuit#238) Card part attributed text patch (intuit#237) Create card part switch component (intuit#236) Add loadspecificcards to README Update CardParts.podspec (intuit#233) Adding a capability to load specific cards added to collection view (intuit#232) Update CardParts.podspec (intuit#231) ...
This fixes #239 and #64
It seems like the only thing that actually needed to be changed was the dependency lines. I recommend an additional PR to bump the Pod version.
I ran this against a project using RxSwift/RxCocoa 5.1.1, Swift 5, and iOS 13 with successful results