Adding dynamic support of height in CardPartPagedView #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevbomb
added a commit
to FireHawkDigital/CardParts
that referenced
this pull request
Sep 2, 2020
…rkmode * 'master' of github.com:FireHawkDigital/CardParts: (23 commits) spacing formatting in podspec Bumping version to 3.1.3 Update CardPartHistogramView.swift Bmping version to 3.1.2 Fix wrong layout on iPad modal presentation Update CardParts.podspec Update CardPartHistogramView.swift (intuit#253) Bump podspec (intuit#251) Adding dynamic support of height in CardPartPagedView (intuit#244) Bump podspec (intuit#250) Update RxCocoa/Swift/DataSource/Gesture (intuit#243) Update CardParts.podspec (intuit#241) Card Parts Bottom Sheet View Controller (intuit#240) Update CardParts.podspec (intuit#238) Card part attributed text patch (intuit#237) Create card part switch component (intuit#236) Add loadspecificcards to README Update CardParts.podspec (intuit#233) Adding a capability to load specific cards added to collection view (intuit#232) Update CardParts.podspec (intuit#231) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you make a Pull Request, read the important guidelines:
Issue Link 🔗
This is an additional capability in CardPartPagedView to dynamically update the height of the view after it has already been instantiated. And it will not break any existing capability.
Goals of this PR 🎉
We are using CardParts in Mint and specifically for bills overview card we are using CardPartPagedView component [which is similar to pageViewController functionality i.e. provides the ability to have multiple scrollable views in our case horizontal].
We have a requirement of dynamically changing the height of this view when state of this card changes from empty state to data state. [ An empty state is when a user does not have any bills attached or the bills are currently been fetched. Data state is when user’s bills have been fetched and ready for display ]. When the bills are in empty state lets say the height of the bills overview should be 400 and when the bills have been fetched we have to resize the bills overview card to 350.
How Has This Been Tested 🔍
We have tested this PR with Mint app and the changes works fine everywhere.
Things to check on 🎯