Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Retry for Agents Starting HttpServer #293

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Jan 11, 2024

Implement Retry for Agents Starting HttpServer
The most common reason for agents not being able to connect to the controller and requiring a restart (terminating that instance and spinning up a new one) observed so far is its inability to start its HttpServer. The cause has been pinpointed: another service is running on that port, and the agent fails to connect and throws an error, causing it to terminate. This has now been fixed to retry the call to start the httpserver, saving time in which the agent will come up (on average 40-60 seconds delay compare to terminating and restarting (4+ mins). This issue rarely occurs per job run, but the likelihood increases as the number of agents started at once increases (most likely will run into this when running 100+ agents at once). This change will allow the job to run with the same amount of agents it first began with, simply waiting for the failing agent to connect instead of terminating it.

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review January 11, 2024 20:28
@Zakaria-Kofiro Zakaria-Kofiro merged commit 60bd3f9 into master Jan 11, 2024
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/no-more-restarts branch January 11, 2024 21:37
kevin-mcgoldrick added a commit that referenced this pull request Feb 1, 2024
* master:
  update position pointer to loop subnet list (#295)
  Initialize Agents Before Starting Load (#294)
  Implement Retry for Agents Starting HttpServer (#293)
  allow any ramp rate value per agent (#292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants