Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop through list of Subnet IDs in AmazonInstance #295

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Loop through list of Subnet IDs in AmazonInstance #295

merged 1 commit into from
Jan 31, 2024

Conversation

Zakaria-Kofiro
Copy link
Collaborator

Loop through list of Subnet IDs in AmazonInstance
Small update to reset pointer to start of list to loop through subnetIds and divide instances between subnets

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro changed the title Fix: Loop through list of Subnet IDs in AmazonInstance Loop through list of Subnet IDs in AmazonInstance Jan 31, 2024
@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review January 31, 2024 23:15
@Zakaria-Kofiro Zakaria-Kofiro merged commit aee1e7f into master Jan 31, 2024
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/subnet-fix branch January 31, 2024 23:41
kevin-mcgoldrick added a commit that referenced this pull request Feb 1, 2024
@kevin-mcgoldrick
Merge branch 'master' into jakarta2023
4aa63ad 
* master:
  update position pointer to loop subnet list (#295)
  Initialize Agents Before Starting Load (#294)
  Implement Retry for Agents Starting HttpServer (#293)
  allow any ramp rate value per agent (#292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-mcgoldrick kevin-mcgoldrick kevin-mcgoldrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zakaria-Kofiro @kevin-mcgoldrick