Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a component based on UITextView #212

Closed
rcole34 opened this issue Dec 12, 2019 · 2 comments
Closed

Add a component based on UITextView #212

rcole34 opened this issue Dec 12, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@rcole34
Copy link
Contributor

rcole34 commented Dec 12, 2019

Existing CardParts are built around UILabel or UITextField, which lack some of the customizable power of UITextView. For instance, you can set the attributedText property of these other components, but links in attributed text are only clickable in UITextView. Additionally, I am not aware of the other UIKit text components having the ability to set exclusion paths to be able to wrap text around images in the way that UITextView can.

Attributed text gives us the ability to customize a lot about the text itself, but we would like to be able to have links in attributed text, and set exclusion paths to improve text wrapping capabilities. These are the main use cases I have in mind, but other attributes of UITextView should be explored and supported in a new feature.

Active Label takes an interesting approach to a similar issue of being able to have hyperlinks, as does TTTAttributedLabel. However, both of those come with their own issues, and still do not seem to be built on UITextView. We can also investigate https://github.com/ReactiveX/RxSwift/blob/master/RxCocoa/iOS/UITextView%2BRx.swift for bindings of UITextView properties with RxSwift.

@rcole34 rcole34 added the enhancement New feature or request label Dec 12, 2019
@lwdupont
Copy link
Contributor

Semi-similar idea - a card part that can render markup?

@croossin
Copy link
Contributor

croossin commented Jan 7, 2020

This has been completed by PR #214 and released in version 2.23.0

@croossin croossin closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants