Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/issue 2/multiple directories in repository #3

Merged
merged 5 commits into from
Apr 26, 2019
Merged

Bugfix/issue 2/multiple directories in repository #3

merged 5 commits into from
Apr 26, 2019

Commits on Apr 26, 2019

  1. Issue #2: Dockerfile: install of dependencies in Docker 

    The Dockerfile was incorrectly setting the list of
dependencies. It should be from the requirements.txt

This time the image is correctly built with the
dependencies, if new ones are added.
    @marcellodesales
    marcellodesales committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    8dfb934 View commit details
    Browse the repository at this point in the history

  2. Issue #2: requirements.txt: adding dependency to glob2 

    In a preliminary test, the glob does NOT look at recursive
directories when doing search.

https://github.com/miracle2k/python-glob2/#recursive-glob

Using the documented approach: "**/*.json" would be the
recursive way.

***** TEST ****

Adding a dir "idps/idps.sh" it did not get listed.

remote: ##################################################
remote: ###### Spring Cloud Config Validator 1.1.0 #######
remote: ##################################################
remote: Validating new branch... HHHEEEERRREEE
remote: Processing commit=48414f981d5fb044fcd19b6518d11b9683407016 ref=refs/heads/develop
remote: Processing file config_msaas_test_01-e2e.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prd.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-dev.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/idps-config.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: CREATING DIR FOR CONTEXT: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file idps/idps.yaml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file config_msaas_test_01.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prf.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/common.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file application.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
echo ""
remote: Processing file config_msaas_test_01-qal.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file README.md to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: => Validating SHA 48414f981d5fb044fcd19b6518d11b9683407016
remote: Looking for files matching  ['*.json', '*.yaml', '*.yml', '*.properties']
remote: (v) File config_msaas_test_01-prd.yml is valid!
echo "Copy the current validator script to the data container"
remote: (v) File config_msaas_test_01-e2e.yml is valid!
remote: (v) File config_msaas_test_01-qal.yml is valid!
remote: (v) File config_msaas_test_01.yml is valid!
remote: (v) File application.yml is valid!
remote: (v) File config_msaas_test_01-dev.yml is valid!
remote: (v) File config_msaas_test_01-prf.yml is valid!
    @marcellodesales
    marcellodesales committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    c0792f7 View commit details
    Browse the repository at this point in the history

  3. Issue #2: Adding docker-compose.yaml to simplify 

    Creating the docker image with proper name and
version. This will improve the local setup and
testing of the packages.
    @marcellodesales
    marcellodesales committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    3452639 View commit details
    Browse the repository at this point in the history

  4. Issue #2: Showing the filters for search of files

    @marcellodesales
    marcellodesales committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    52c89ae View commit details
    Browse the repository at this point in the history

  5. Issue #2: Showing the list of filtered files

    @marcellodesales
    marcellodesales committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    0d15173 View commit details
    Browse the repository at this point in the history