Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dependencies #14

Closed
wants to merge 1 commit into from
Closed

Updates dependencies #14

wants to merge 1 commit into from

Conversation

perploug
Copy link

@perploug perploug commented Apr 1, 2019

Updates package dependencies to their latest versions to patch security issues.

  • Updated dependencies and devdependencies in package.json
  • Updated the test coverage to nyc from instanbul
  • Tests are passing

Signed-off-by: Per Ploug <per.ploug@zalando.de>
@tallbrick
Copy link

@perploug it looks like you'll need to update the Travis CI config files to be compatible with your changes (note the above build errors). const and let weren't supported until at least Node v6.0.0.

You should consider updating this property in the .travis.yml:

node_js:
- '8.0.0'
- '7.0.0'
- '6.0.0'
- iojs

Of course you could also use more recent node versions as well...
https://node.green/

@tallbrick
Copy link

@marcellodesales

This PR resolves some nasty vulerabilities (which puts the ongoing use of this lib in question). Any chance you could review this one?

@marcellodesales
Copy link
Member

@tallbrick I will get to it during hacktoberfest!

@marcellodesales
Copy link
Member

@tallbrick @perploug any interest in updating the travis build with the recent versions of node? I can merge this PR soon after the build passes...

@marcellodesales
Copy link
Member

Done on #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants