Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Native Promises + Upgrade dependencies #16

Merged
merged 5 commits into from
Nov 26, 2019

Conversation

FauxFaux
Copy link
Contributor

This is a second attempt at #14, broken into parts, and with the feedback incorporated.

  • update coverage setup according to current nyc (istanbul) and coveralls documentation
  • remove unused sinon dependency
  • upgrade other dev dependencies (no changes needed)
  • switch away from Bluebird to native promises, as node supports them now, and our needs are trivial.

Signed-off-by: Chris West (Faux) <git@goeswhere.com>
Signed-off-by: Chris West (Faux) <git@goeswhere.com>
Signed-off-by: Chris West (Faux) <git@goeswhere.com>
Signed-off-by: Chris West (Faux) <git@goeswhere.com>
@coveralls
Copy link

coveralls commented Nov 22, 2019

Coverage Status

Coverage remained the same at 87.097% when pulling 7cb2cb6 on FauxFaux:upgrade-deps into d59c365 on intuit:master.

Signed-off-by: Chris West (Faux) <git@goeswhere.com>
@marcellodesales
Copy link
Member

LGTM

@marcellodesales marcellodesales merged commit 8189417 into intuit:master Nov 26, 2019
@marcellodesales marcellodesales modified the milestones: 2.0.0, 1.1.2 Nov 26, 2019
@marcellodesales
Copy link
Member

@FauxFaux thanks a lot for your contribution!!! I will cut a release during the holiday weekend!

This was referenced Nov 26, 2019
@FauxFaux FauxFaux deleted the upgrade-deps branch November 29, 2019 17:45
@marcellodesales marcellodesales mentioned this pull request Dec 26, 2019
3 tasks
@marcellodesales marcellodesales changed the title Upgrade dependencies Use Native Promises + Upgrade dependencies Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants