Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why 300 as base width? #33

Closed
rajsuvariya1 opened this issue Jan 15, 2018 · 3 comments
Closed

Why 300 as base width? #33

rajsuvariya1 opened this issue Jan 15, 2018 · 3 comments

Comments

@rajsuvariya1
Copy link

As per android buckets for mdpi (360 width) 1dp = 1px. So why are you using 300 as a base and why not 360??. If you use 360 as base then we can directly assign values provided in px to sdp.

@elhanan-mishraky
Copy link
Contributor

@rajsuvariya1 you might be right, but for backward compatibility I'm afraid that I won't be able to change it now. Anyway, if you need 1sdp = 1px conversation resize the mockup you have to 300px width with some image editor.

@rajsuvariya
Copy link

Just a question in the script if I change 300 to 360 while finding out ratio it should work right?

@elhanan-mishraky
Copy link
Contributor

Yes, you got it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants