Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refs #379] [objects.flag|media] Use flexbox #383

Merged
merged 11 commits into from
Jun 8, 2020
Merged

[refs #379] [objects.flag|media] Use flexbox #383

merged 11 commits into from
Jun 8, 2020

Conversation

florianbouvot
Copy link
Member

  • Use flexbox in objects.media
  • Add vertical alignement modifiers in objects.media
  • Remove objects.flag

@nenadjelovac
Copy link
Member

I actually prefer flag naming because it doesn't imply use (which media kinda does :))

@florianbouvot
Copy link
Member Author

@nenadjelovac I will switch to flag (I choose media because it's the historical and common name).

@herzinger
Copy link
Contributor

herzinger commented Oct 16, 2018

How does media imply more use than flag? It's the same, in my opinion, and the media object has a pretty significant historic meaning, being the origin of the OOCSS methodology and all...

@florianbouvot
Copy link
Member Author

@inuitcss/core What name did you prefer: media or flag?

Copy link
Member

@csshugs csshugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You now removed the media object, instead the flag object as you proposed. I think we should definitely keep the media object and abandon the flag object as the media object is much better known in the community.

@florianbouvot
Copy link
Member Author

@csshugs I switch back to media.

@nenadjelovac
Copy link
Member

Actually, you guys are right.

I just stated my personal preference/view about whole media vs flag naming thing, but guess it's not aligned with community's ;) Glad we've reached an agreement about how to move forward.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
objects/_objects.media.scss Outdated Show resolved Hide resolved
@csshugs
Copy link
Member

csshugs commented Jun 8, 2020

@nenadjelovac @florianbouvot
Any more reservations? Approved for merge?

@florianbouvot
Copy link
Member Author

@csshugs LGTM

@csshugs csshugs merged commit 037aabc into v7.0.0 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants