-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refs #379] [objects.flag|media] Use flexbox #383
Conversation
florianbouvot
commented
Oct 13, 2018
- Use flexbox in objects.media
- Add vertical alignement modifiers in objects.media
- Remove objects.flag
I actually prefer flag naming because it doesn't imply use (which media kinda does :)) |
@nenadjelovac I will switch to flag (I choose media because it's the historical and common name). |
How does media imply more use than flag? It's the same, in my opinion, and the media object has a pretty significant historic meaning, being the origin of the OOCSS methodology and all... |
@inuitcss/core What name did you prefer: media or flag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You now removed the media object, instead the flag object as you proposed. I think we should definitely keep the media object and abandon the flag object as the media object is much better known in the community.
@csshugs I switch back to |
Actually, you guys are right. I just stated my personal preference/view about whole media vs flag naming thing, but guess it's not aligned with community's ;) Glad we've reached an agreement about how to move forward. |
77bcd82
to
6d6b274
Compare
@nenadjelovac @florianbouvot |
@csshugs LGTM |