Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for neverending drag mode on horizontal scrollbar disappear #371

Closed
wants to merge 1 commit into from

Conversation

schweighart
Copy link

If you have a horizontal scrollbar (and no vertical) which can only scroll a few pixel it dissapears on dragging it in Firefox. In this case the drag mode is not disabled and every time the mouse is moved it is interpreted as a drag and focus is removed from the current active element.

@inuyaksa
Copy link
Owner

inuyaksa commented Oct 9, 2014

Thanks for this fix, I'll merge soon

inuyaksa added a commit that referenced this pull request Nov 10, 2014
List of fixes:
- scriptpath, Allows users to define their own "scriptpath" #309
- Rail positioning bug when hwacceleration is off in Chrome browser #447
- Scroll is Positioned at Page Bottom in Chrome. Nicescroll v 3.5.6 #443
- Uncaught TypeError: Cannot read property 'win' of null #439
- Multi-Touch gestures - OS X #431
- Nicescroll bar rail jumps after resize #425
- nicescroll rail positioned at the bottom in chrome when refreshing
page that has scroll #424
- CTRL-F not working do nicescroll #419
- IE 11 - touch support #418
- Multiple nicescroll containers can't use same config car? #409
- "*niceBar.locked = true" --- Unlocked by browser window resizing #408
- Scrollbar displayed but not scrollable on IE11 with Windows 8 touch
device #407
- this.getViewport doesn't check for relative #403
- Chrome Search on Windows breaks NiceScroll #400
- Vertical scrollbar problem in Chrome 35 when the scroll of the body is
greater than 0 #394
- Scroll position on page reload - Latest version (3.5.4) #387
- Incorrect scrollbar position after reload in Chrome #372
- Problem on expresion: /BODY|HTML/.test(dom.nodeName) #292
- Ctrl + mouse wheel - scrolling instead zooming in Firefox and IE #275
- Remove - Uncaught TypeError: Cannot set property 'onsync' of null #247
- JS Error in console: Uncaught TypeError: Cannot read property
'defaultView' of null  #245
- Touch support for W3C Pointer Events #420
- railpadding/railoffset fixed #413
- Fix for neverending drag mode on horizontal scrollbar disappear #371
- fixed 'use strict' errors #355
- Readability and maintainability improvement #336
- Update jquery.nicescroll.js #325
inuyaksa added a commit that referenced this pull request Nov 21, 2014
New options
- scriptpath, Allows users to define their own "scriptpath" #309

Changed features
- Primitive bootstrap support - modal windows #449
- removed delayed method

Fixes
- Rail positioning bug when hwacceleration is off in Chrome browser #447
- Scroll is Positioned at Page Bottom in Chrome. Nicescroll v 3.5.6 #443
- Uncaught TypeError: Cannot read property 'win' of null #439
- Multi-Touch gestures - OS X #431
- Nicescroll bar rail jumps after resize #425
- nicescroll rail positioned at the bottom in chrome when refreshing
page that has scroll #424
- CTRL-F not working do nicescroll #419
- IE 11 - touch support #418
- Multiple nicescroll containers can't use same config car? #409
- "*niceBar.locked = true" --- Unlocked by browser window resizing #408
- Scrollbar displayed but not scrollable on IE11 with Windows 8 touch
device #407
- this.getViewport doesn't check for relative #403
- Chrome Search on Windows breaks NiceScroll #400
- Vertical scrollbar problem in Chrome 35 when the scroll of the body is
greater than 0 #394
- Scroll position on page reload - Latest version (3.5.4) #387
- Incorrect scrollbar position after reload in Chrome #372
- Problem on expresion: /BODY|HTML/.test(dom.nodeName) #292
- Ctrl + mouse wheel - scrolling instead zooming in Firefox and IE #275
- Remove - Uncaught TypeError: Cannot set property 'onsync' of null #247
- JS Error in console: Uncaught TypeError: Cannot read property
'defaultView' of null  #245
- railposition outside a fixed div in Chrome 38 and IE not correct #450
- Preserve Vertical scroll behavior after horizontal scrolling ends #451
- Wrapped divs, fix rail position for content already scrolled
- Detect content appends to page, refresh rail positions
- Nicescrolls are not located in the new positions #446
- Chrome, dragging cursor on touchbehavior losts mouse move
- cantouch capability is detected as a false positive in WebKitGTK+ #367
- Scrolling via touch not working on certain non-IOS webkit browsers
(namely Cisco's IEC 4600 series) #389
- Chrome, cursor drag on "touchbehavior"=TRUE
- IE10+ drag lock issue

Coding notes
- Initial code rewriting to detach legacy browser support for current
code

Thanks to contributors!!
- Touch support for W3C Pointer Events #420
- railpadding/railoffset fixed #413
- Fix for neverending drag mode on horizontal scrollbar disappear #371
- fixed 'use strict' errors #355
- Readability and maintainability improvement #336
- Update jquery.nicescroll.js #325
- cantouch capability is detected as a false positive in WebKitGTK+ #368
@inuyaksa inuyaksa closed this Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants