Fixed bug: cantouch capability is detected as a false positive in WebKitGTK+ #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inuyaksa
added a commit
that referenced
this pull request
Apr 29, 2014
Fixed bug: cantouch capability is detected as a false positive in WebKitGTK+
|
Thanks for create this fix! |
|
Welcome. Thank you for integrating it. |
inuyaksa
added a commit
that referenced
this pull request
Nov 21, 2014
New options - scriptpath, Allows users to define their own "scriptpath" #309 Changed features - Primitive bootstrap support - modal windows #449 - removed delayed method Fixes - Rail positioning bug when hwacceleration is off in Chrome browser #447 - Scroll is Positioned at Page Bottom in Chrome. Nicescroll v 3.5.6 #443 - Uncaught TypeError: Cannot read property 'win' of null #439 - Multi-Touch gestures - OS X #431 - Nicescroll bar rail jumps after resize #425 - nicescroll rail positioned at the bottom in chrome when refreshing page that has scroll #424 - CTRL-F not working do nicescroll #419 - IE 11 - touch support #418 - Multiple nicescroll containers can't use same config car? #409 - "*niceBar.locked = true" --- Unlocked by browser window resizing #408 - Scrollbar displayed but not scrollable on IE11 with Windows 8 touch device #407 - this.getViewport doesn't check for relative #403 - Chrome Search on Windows breaks NiceScroll #400 - Vertical scrollbar problem in Chrome 35 when the scroll of the body is greater than 0 #394 - Scroll position on page reload - Latest version (3.5.4) #387 - Incorrect scrollbar position after reload in Chrome #372 - Problem on expresion: /BODY|HTML/.test(dom.nodeName) #292 - Ctrl + mouse wheel - scrolling instead zooming in Firefox and IE #275 - Remove - Uncaught TypeError: Cannot set property 'onsync' of null #247 - JS Error in console: Uncaught TypeError: Cannot read property 'defaultView' of null #245 - railposition outside a fixed div in Chrome 38 and IE not correct #450 - Preserve Vertical scroll behavior after horizontal scrolling ends #451 - Wrapped divs, fix rail position for content already scrolled - Detect content appends to page, refresh rail positions - Nicescrolls are not located in the new positions #446 - Chrome, dragging cursor on touchbehavior losts mouse move - cantouch capability is detected as a false positive in WebKitGTK+ #367 - Scrolling via touch not working on certain non-IOS webkit browsers (namely Cisco's IEC 4600 series) #389 - Chrome, cursor drag on "touchbehavior"=TRUE - IE10+ drag lock issue Coding notes - Initial code rewriting to detach legacy browser support for current code Thanks to contributors!! - Touch support for W3C Pointer Events #420 - railpadding/railoffset fixed #413 - Fix for neverending drag mode on horizontal scrollbar disappear #371 - fixed 'use strict' errors #355 - Readability and maintainability improvement #336 - Update jquery.nicescroll.js #325 - cantouch capability is detected as a false positive in WebKitGTK+ #368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While having a look at https://bugs.webkit.org/show_bug.cgi?id=129680, Diego Pino (dpino@igalia.com) and Enrique Ocaña (eocanha@igalia.com) realized that nicescroll was detecting WebKitGTK+ running on desktop as having "cantouch" capabilities. WebKitGTK+ and, in general, all WebKit based browsers, should have the same treatment as Chrome.