Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quotes from project_shortname #45

Closed
fenekku opened this issue Feb 19, 2020 · 2 comments · Fixed by #61
Closed

Remove quotes from project_shortname #45

fenekku opened this issue Feb 19, 2020 · 2 comments · Fixed by #61
Assignees
@ppanero
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@fenekku
Copy link
Contributor

fenekku commented Feb 19, 2020

Passing: "Pablo's Version" as project_name, results in pablo's-version as project_shortname, but it should result in pablos-version
@ppanero
Copy link
Member

ppanero commented Feb 20, 2020

Basically we should sanitize the input? That's more a base cookiecutter thing rather than here. We have no control over it once we call the cookiecutter.

@fenekku
Copy link
Contributor Author

fenekku commented Feb 20, 2020

This is what needs to be changed: https://github.com/inveniosoftware/cookiecutter-invenio-rdm/blob/master/cookiecutter.json#L3

@lnielsen lnielsen added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Mar 18, 2020
@ppanero ppanero mentioned this issue Mar 23, 2020
Closed
33 tasks
@ppanero ppanero self-assigned this Mar 25, 2020
@ppanero ppanero mentioned this issue Mar 27, 2020
Merged
@fenekku fenekku mentioned this issue Apr 28, 2020
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppanero ppanero

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: load slugify extension and use for project_shortname ppanero/cookiecutter-invenio-rdm
3 participants
@lnielsen @fenekku @ppanero