Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROR autocomplete lack of country results in incorrect selection #1868

Closed
tmorrell opened this issue Sep 8, 2022 · 3 comments · Fixed by inveniosoftware/invenio-vocabularies#295
Labels
bug Something isn't working

Comments

@tmorrell
Copy link
Contributor

tmorrell commented Sep 8, 2022

Package version (if known): v9.1

Describe the bug

Since the Affiliation and Funder ROR autocomplete lacks country information, funders with common names like "National Institute of Health" can't be distinguished.

Steps to Reproduce

  1. Go to Funding, Add custom

  2. Search National Institute of Health

  3. See there are two identical options:
    Screen Shot 2022-09-08 at 3 14 30 PM

  4. If you select the first one, you've picked the National Institute of Health in Pakistan

  5. Go to Add creator, Affiliation

  6. Search National Institute of Health

  7. The first option seems to be correct
    Screen Shot 2022-09-08 at 3 34 03 PM

  8. But it's the NIH in Pakistan again

Expected behavior

ROR autocompletes include the country, to distinguish RORs with the same name.

Screenshots (if applicable)

Additional context

@ntarocco
Copy link
Contributor

ntarocco commented May 5, 2023

Related issue: in the record landing page, we don't display the ROR id and country (basically, more info) for funders, in the Funders tab in the bottom of the landing page.

@zzacharo
Copy link
Member

zzacharo commented May 5, 2023

Related issue/clarification: @tmorrell I noticed that if you enter a creator/contributor as organization, then only required field is the free text name.

Now, if you enter a Name Identifier that can be any valid ROR/allowed scheme identifier, at the moment, there is no check/curation of the user's input if the identifier is matched and the displayed name is not accurate.

That said, there are pros and cons to overriding/allowing the user's input over the matched identifier but my question is if this is something we need to consider implementing as part of this issue (in the general context of ROR integration improvement).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Jul 5, 2023
@tmorrell tmorrell removed the stale No activity for more than 60 days. label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants