Create moderation request on publish #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandromumo
force-pushed
the
create_moderation_request_on_publish
branch
4 times, most recently
from
d963a24
to
9f2c5cb
Compare
alejandromumo
commented
Aug 16, 2023
tests/conftest.py
Outdated
|
|
||
| # Users are verified by default. This will disable the automatic creation of moderation requests after publishing a record. | ||
| # When testing unverified users, there is a "unverified_user" fixture for that purpose. | ||
| app_config["ACCOUNTS_DEFAULT_VERIFIED_STATUS"] = True |
There was a problem hiding this comment.
This simplifies testing.
That way, after publish there are no moderation requests created in tests and it's easier to test user moderation (I created explicit users for that purpose).
alejandromumo
commented
Aug 16, 2023
| is_verified = record.parent.is_verified | ||
|
|
||
| # Owner might not resolve to a User (e.g. when the record was created by system) | ||
| owner_exists = record.parent.access.owner.owner_id |
There was a problem hiding this comment.
Try to identify if it's the system.
alejandromumo
force-pushed
the
create_moderation_request_on_publish
branch
2 times, most recently
from
b335389
to
5306807
Compare
zzacharo
reviewed
Aug 18, 2023
| records_service.update_draft( | ||
| unverified_user.identity, new_version.id, minimal_record | ||
| ) | ||
| # Since tasks are executed synchronously in tests, the db session that is rolledback inside the session |
There was a problem hiding this comment.
rephrase a bit to depict what is wrong?
zzacharo
reviewed
Aug 18, 2023
| @@ -47,11 +69,17 @@ def test_user_moderation_approve( | |||
|
|
|||
| assert is_verified == False | |||
|
|
|||
| moderation_request = mod_request_create(uploader.id) | |||
| # Approve the user | |||
alejandromumo
force-pushed
the
create_moderation_request_on_publish
branch
from
5306807
to
42f8967
Compare
zzacharo
approved these changes
Aug 18, 2023
zzacharo
force-pushed
the
create_moderation_request_on_publish
branch
2 times, most recently
from
6957ab3
to
32c273f
Compare
zzacharo
force-pushed
the
create_moderation_request_on_publish
branch
from
32c273f
to
905230d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes inveniosoftware/invenio-requests#344
Needs: