moderation: restrict request duplication. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandromumo
force-pushed
the
restrict_duplicated_moderation_requests
branch
2 times, most recently
from
d69fce4
to
da6b87d
Compare
alejandromumo
commented
Aug 16, 2023
| ) | ||
| return request | ||
| except OpenRequestAlreadyExists: | ||
| # Avoid rolling back the uow if a request already exists, since there is nothing to rollback. |
There was a problem hiding this comment.
what to do here?
Return the error, similar to community inclusion
alejandromumo
force-pushed
the
restrict_duplicated_moderation_requests
branch
from
da6b87d
to
18fd835
Compare
alejandromumo
force-pushed
the
restrict_duplicated_moderation_requests
branch
from
18fd835
to
4e82b6a
Compare
zzacharo
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #344