Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibdocfile: OCR text-file is not deleted when related version of full-text file is deleted. #3519

Closed
Kennethhole opened this issue Sep 21, 2015 · 4 comments

Comments

@Kennethhole
Copy link
Member

The PURGE function in bibupload deletes the old versions of a file, but the .text;1 file which contains the OCR for the previous version is not deleted.

The .text;1 file is dropped from the indexer with once the .text;2 file is created and is just stored as an unused file. As the file has no function it should be deleted.

-rw-r--r--  1 apache apache 122079 sep  9 10:59 content.jpg;icon;2
-rw-r--r--  1 apache apache 179315 sep  9 10:59 content.pdf;2
-rw-r--r--  1 apache apache    202 sep  9 10:59 .md5
-rw-r--r--  1 apache apache     19 sep  3 19:55 .reclinks
-rw-r--r--  1 apache apache   8871 sep  3 19:56 .text;1
-rw-r--r--  1 apache apache   8892 sep  9 10:59 .text;2
@kaplun
Copy link
Member

kaplun commented Sep 21, 2015

Actually the whole bibdoc directory could be happily removed recursively when the corresponding BibDoc is expunged.

EDIT: that is indeed what happens for expunge already. But the bug is about purge action.

@kaplun kaplun added this to the v1.1.7 milestone Sep 21, 2015
@tiborsimko
Copy link
Member

@Kennethhole @kaplun Any updates on this? Solved locally within TIND? I'm moving the issue to v1.1.8.

@tiborsimko tiborsimko modified the milestones: v1.1.8, v1.1.7 Nov 14, 2016
kaplun added a commit to kaplun/invenio that referenced this issue Nov 14, 2016
* FIX Purges old extracted text too, when purging a BibDoc.
  (closes inveniosoftware#3519)

Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
@kaplun
Copy link
Member

kaplun commented Nov 14, 2016

@tiborsimko was faster to implement the fix, than to reply I had no news about it 💃

@kaplun kaplun modified the milestones: v1.1.7, v1.1.8 Nov 14, 2016
@tiborsimko
Copy link
Member

Closed by #3719.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants