Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BibDocFile: escape file URLs in /files tab #2067

Conversation

ludmilamarian
Copy link
Contributor

Co-authored by: Jerome Caffaro jerome.caffaro@cern.ch
Signed-off-by: Ludmila Marian ludmila.marian@gmail.com

Co-authored by: Jerome Caffaro <jerome.caffaro@cern.ch>
Signed-off-by: Ludmila Marian <ludmila.marian@gmail.com>
@@ -366,7 +366,7 @@ def tmpl_bibdocfile_filelist(self, ln, recid, name, version, md, superformat, su

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1: D100 Docstring missing
2: I102 copyright year is outdated, expected 2014 but got 2013
22:6: E126 continuation line over-indented for hanging indent
28:1: E302 expected 2 blank lines, found 1
28: D401 First line should be imperative: 'Retrieve', not 'Retrieves'
41:1: E302 expected 2 blank lines, found 1
51:1: E302 expected 2 blank lines, found 1
51: D101 Docstring missing
55:30: E261 at least two spaces before inline comment
56:30: E261 at least two spaces before inline comment
57:17: E203 whitespace before ':'
57:30: E261 at least two spaces before inline comment
58:18: E203 whitespace before ':'
58:30: E261 at least two spaces before inline comment
59:32: E261 at least two spaces before inline comment
60:30: E261 at least two spaces before inline comment
62:5: E301 expected 1 blank line, found 0
62: D401 First line should be imperative: 'Return', not 'Returns'
86:31: F841 local variable 'dummy' is assigned to but never used
100:29: E126 continuation line over-indented for hanging indent
100:35: E203 whitespace before ':'
101:38: E203 whitespace before ':'
102:28: E126 continuation line over-indented for hanging indent
106:53: E128 continuation line under-indented for visual indent
107:53: E128 continuation line under-indented for visual indent
108:53: E128 continuation line under-indented for visual indent
120:19: E126 continuation line over-indented for hanging indent
121:24: E251 unexpected spaces around keyword / parameter equals
121:26: E251 unexpected spaces around keyword / parameter equals
123:17: E121 continuation line under-indented for hanging indent
126: D401 First line should be imperative: 'Display', not 'Displays'
126: D202 No blank lines allowed after method docstring, found 1
144:9: F841 local variable '' is assigned to but never used
160: D401 First line should be imperative: 'Display', not 'Displays'
160: D202 No blank lines allowed after method docstring, found 1
194:53: E251 unexpected spaces around keyword / parameter equals
194:55: E251 unexpected spaces around keyword / parameter equals
194: D401 First line should be imperative: 'Return', not 'Returns'
197:18: E126 continuation line over-indented for hanging indent
197:20: E251 unexpected spaces around keyword / parameter equals
197:22: E251 unexpected spaces around keyword / parameter equals
198:23: E251 unexpected spaces around keyword / parameter equals
198:25: E251 unexpected spaces around keyword / parameter equals
199:25: E251 unexpected spaces around keyword / parameter equals
199:27: E251 unexpected spaces around keyword / parameter equals
200:20: E251 unexpected spaces around keyword / parameter equals
200:22: E251 unexpected spaces around keyword / parameter equals
201:22: E251 unexpected spaces around keyword / parameter equals
201:24: E251 unexpected spaces around keyword / parameter equals
202:29: E251 unexpected spaces around keyword / parameter equals
202:31: E251 unexpected spaces around keyword / parameter equals
203:27: E251 unexpected spaces around keyword / parameter equals
203:29: E251 unexpected spaces around keyword / parameter equals
204:29: E251 unexpected spaces around keyword / parameter equals
204:31: E251 unexpected spaces around keyword / parameter equals
205:29: E251 unexpected spaces around keyword / parameter equals
205:31: E251 unexpected spaces around keyword / parameter equals
206:16: E126 continuation line over-indented for hanging indent
208: D401 First line should be imperative: 'Return', not 'Returns'
239:29: E126 continuation line over-indented for hanging indent
239:38: E203 whitespace before ':'
240:39: E203 whitespace before ':'
241:38: E203 whitespace before ':'
242:27: E126 continuation line over-indented for hanging indent
247:91: E251 unexpected spaces around keyword / parameter equals
247:93: E251 unexpected spaces around keyword / parameter equals
252:19: E251 unexpected spaces around keyword / parameter equals
252:21: E251 unexpected spaces around keyword / parameter equals
253:25: E251 unexpected spaces around keyword / parameter equals
253:27: E251 unexpected spaces around keyword / parameter equals
254:25: E251 unexpected spaces around keyword / parameter equals
254:27: E251 unexpected spaces around keyword / parameter equals
255:24: E251 unexpected spaces around keyword / parameter equals
255:26: E251 unexpected spaces around keyword / parameter equals
256:22: E251 unexpected spaces around keyword / parameter equals
256:24: E251 unexpected spaces around keyword / parameter equals
257:23: E251 unexpected spaces around keyword / parameter equals
257:25: E251 unexpected spaces around keyword / parameter equals
264:5: E303 too many blank lines (3)
264: D401 First line should be imperative: 'Display', not 'Displays'
302:22: E126 continuation line over-indented for hanging indent
302:32: E203 whitespace before ':'
303:31: E203 whitespace before ':'
305:20: E126 continuation line over-indented for hanging indent
308:30: E222 multiple spaces after operator
309:34: E126 continuation line over-indented for hanging indent
309:39: E203 whitespace before ':'
310:43: E203 whitespace before ':'
312:43: E203 whitespace before ':'
316:32: E126 continuation line over-indented for hanging indent
326:27: E126 continuation line over-indented for hanging indent
326:36: E203 whitespace before ':'
327:32: E203 whitespace before ':'
328:33: E203 whitespace before ':'
329:25: E126 continuation line over-indented for hanging indent
336: D401 First line should be imperative: 'Display', not 'Displays'
336: D202 No blank lines allowed after method docstring, found 1
363:9: F841 local variable '
' is assigned to but never used
371:29: E203 whitespace before ':'
391:23: E126 continuation line over-indented for hanging indent
391:29: E203 whitespace before ':'
392:34: E203 whitespace before ':'
393:27: E203 whitespace before ':'
394:36: E203 whitespace before ':'
395:21: E126 continuation line over-indented for hanging indent

@ludmilamarian ludmilamarian added this to the v1.2 milestone Aug 8, 2014
@ludmilamarian
Copy link
Contributor Author

invenio-check-branch - ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants