global: expose updateQueryState #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
approved these changes
Mar 30, 2020
topless
force-pushed
the
99-update-query-state
branch
7 times, most recently
from
36262f7
to
3ffb044
Compare
- updateQueryState exposed withState HOC - test for exposed props form withState - documentation - fix for config expecting axios property - fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js - changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101 - closes #99
topless
force-pushed
the
99-update-query-state
branch
from
3ffb044
to
90e015e
Compare
zzacharo
reviewed
Mar 31, 2020
- updateQueryState exposed withState HOC - test for exposed props form withState - documentation - fix for config expecting axios property - fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js - changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101 - closes #99
- updateQueryState exposed withState HOC - test for exposed props form withState - documentation - fix for config expecting axios property - fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js - changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101 - closes #99
zzacharo
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store.js->reducers/index.js->state/reducers/query.js->store.jswithStateHOC component #99