Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow queryState change in withState HOC component #99

Closed
ntarocco opened this issue Mar 27, 2020 · 0 comments · Fixed by #100
Closed

Allow queryState change in withState HOC component #99

ntarocco opened this issue Mar 27, 2020 · 0 comments · Fixed by #100
Assignees
@topless

Comments

@ntarocco
Copy link
Contributor

When an app implements its own custom component using withState HOC component, currently it can only read the state, but not modify it. Add the action updateQueryState to it.

  1. add the action updateQueryState in withState component, as done here
  2. test the changes for filters: given an app with 2 selected filters, e.g. file_type=pdf and language=en, when the new custom components updates language=it, file_type=pdf should be kept as is.
  3. Add tests and update docs and demos if necesssary.
@ntarocco ntarocco mentioned this issue Mar 27, 2020
Merged
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
4e51acb 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- closes #99
@topless topless mentioned this issue Mar 30, 2020
Merged
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
3cb89f5 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- closes #99
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
c7151c7 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
977f18e 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
46a02fa 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
00c566b 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
36262f7 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
topless added a commit that referenced this issue Mar 30, 2020
@topless
global: expose updateQueryState
3ffb044 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
topless added a commit that referenced this issue Mar 31, 2020
@topless
global: expose updateQueryState
90e015e 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
zzacharo pushed a commit to zzacharo/react-searchkit that referenced this issue Mar 31, 2020
@topless @zzacharo
global: expose updateQueryState
95b66d8 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes inveniosoftware#101
- closes inveniosoftware#99
zzacharo pushed a commit that referenced this issue Mar 31, 2020
@topless @zzacharo
global: expose updateQueryState
454b684 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
zzacharo pushed a commit that referenced this issue Mar 31, 2020
@topless @zzacharo
global: expose updateQueryState
99d3f35 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
zzacharo pushed a commit that referenced this issue Mar 31, 2020
@topless @zzacharo
global: expose updateQueryState
e51332b 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
zzacharo pushed a commit that referenced this issue Mar 31, 2020
@topless @zzacharo
global: expose updateQueryState
2f99906 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
zzacharo pushed a commit that referenced this issue Mar 31, 2020
@topless @zzacharo
global: expose updateQueryState
ff68a95 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes #101
- closes #99
zzacharo pushed a commit that referenced this issue Mar 31, 2020
@topless @zzacharo
global: expose updateQueryState
1326069 
- updateQueryState exposed withState HOC
- fix for config expecting axios property
- closes #99
topless added a commit to topless/react-searchkit that referenced this issue Apr 1, 2020
@topless
global: expose updateQueryState
4f77dd1 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes inveniosoftware#101
- closes inveniosoftware#99
topless added a commit to topless/react-searchkit that referenced this issue Apr 1, 2020
@topless
global: expose updateQueryState
ddf53d1 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes inveniosoftware#101
- closes inveniosoftware#99
topless added a commit to topless/react-searchkit that referenced this issue Apr 1, 2020
@topless
global: expose updateQueryState
64839fc 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes inveniosoftware#101
- closes inveniosoftware#99
topless added a commit to topless/react-searchkit that referenced this issue Apr 1, 2020
@topless
global: expose updateQueryState
e0ca4d4 
- updateQueryState exposed withState HOC
- test for exposed props form withState
- documentation
- fix for config expecting axios property
- fix circular dependency src/lib/store.js -> src/lib/state/reducers/index.js -> src/lib/state/reducers/query.js -> src/lib/store.js
- changed initialResultsState.loading to true to avoid double children render in ResultsLoader closes inveniosoftware#101
- closes inveniosoftware#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topless topless

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

global: expose updateQueryState inveniosoftware/react-searchkit
2 participants
@topless @ntarocco