Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA (QR code) when dark mode enabled #4998

Closed
2 of 4 tasks
jelgersma opened this issue Jun 8, 2023 · 3 comments · Fixed by #5000
Closed
2 of 4 tasks

2FA (QR code) when dark mode enabled #4998

jelgersma opened this issue Jun 8, 2023 · 3 comments · Fixed by #5000
Labels
bug Identifies a bug which needs to be addressed user interface User interface
Milestone

Comments

@jelgersma
Copy link

Please verify that this bug has NOT been raised before.

  • I checked and didn't find a similar issue

Describe the bug*

2FA QR code can't be scanned due to gray background when dark mode is enabled for the user.

Steps to Reproduce

  1. Login as user (U) and enable dark mode for your account
  2. Login as admin (A) on another device or incognito
  3. Enforce 2FA for users in Inventree (Settings > Login > Enforce MFA)
  4. Watch U struggle to scan the QR code because the background is gray all the while A is laughing

Expected behaviour

White background for QR code eventhough dark mode is enabled

Deployment Method

  • Docker
  • Bare metal

Version Information

Inventree version 0.11.2
Python Version | 3.9.16
Django Version | 3.2.18

Please verify if you can reproduce this bug on the demo site.

  • I can reproduce this bug on the demo site.

Relevant log output

No response

@jelgersma jelgersma added bug Identifies a bug which needs to be addressed question This is a question triage:not-checked Item was not checked by the core team labels Jun 8, 2023
@SchrodingersGat
Copy link
Member

@jelgersma a screenshot would be handy here :)

@SchrodingersGat SchrodingersGat added user interface User interface and removed question This is a question triage:not-checked Item was not checked by the core team labels Jun 8, 2023
@jelgersma
Copy link
Author

jelgersma commented Jun 8, 2023

2023-06-08 13 56 24

User is using Android Pixel 7 Pro and can't scan the QR when the background is gray (note: on my iphone it just works). When changing the background color to white (through dev console) it works for his phone too. As a fallback I told the user to get a better phone 😬

Edit:
Also happens when scanning for QR code with 1password (password manager). Changing background to white fixes it with 1password too.

@SchrodingersGat
Copy link
Member

@jelgersma fix incoming. You might not have to ship better phones to everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed user interface User interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants