Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/switch-template-nasport2index #5779

Merged
merged 4 commits into from
Sep 16, 2020
Merged

feature/switch-template-nasport2index #5779

merged 4 commits into from
Sep 16, 2020

Conversation

jrouzierinverse
Copy link
Member

@jrouzierinverse jrouzierinverse commented Sep 8, 2020 •
edited by nqb
Loading

Description

Switch templates can define how to map a NasPort to an IfIndex

Impacts

Switch Templates

NEWS file entries

Enhancements

  • Switch templates can define how to map a NasPort to an IfIndex

Issue

fixes #5776

Delete branch after merge

NO

Checklist

  • Document the feature
  • Add unit tests
  • Add acceptance tests (TestLink)

@nqb nqb mentioned this pull request Sep 9, 2020
Closed
@nqb
Copy link
Contributor

nqb commented Sep 9, 2020

@jrouzierinverse, ready to review ?

@nqb nqb self-requested a review September 9, 2020 14:28
@nqb nqb self-assigned this Sep 9, 2020
nqb
nqb suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@nqb nqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI send correct informations in API call but template_switches.conf is not patched with nasPortToIfindex parameter.

It works if I add by hand parameter in file.

@jrouzierinverse
Copy link
Member Author

This has been fixed.

@nqb nqb force-pushed the feature/switch-template-nasport2index branch 2 times, most recently from ce672b4 to 04341c1 Compare September 16, 2020 09:53
@nqb nqb force-pushed the feature/switch-template-nasport2index branch from 04341c1 to 4509009 Compare September 16, 2020 13:02
@nqb nqb merged commit f9fe3b8 into devel Sep 16, 2020
nqb added a commit that referenced this pull request Sep 16, 2020
@nqb
news for #5779 and #5758
c47706d
satkunas pushed a commit that referenced this pull request Dec 11, 2020
@nqb @satkunas
news for #5779 and #5758
e7ad549
@satkunas satkunas deleted the feature/switch-template-nasport2index branch May 15, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqb nqb nqb requested changes

Assignees

@nqb nqb

Labels
Status: For review Type: Feature / Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NasPortToIfIndex for switch templates
2 participants
@jrouzierinverse @nqb