Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0-alpha.3 #102

Merged
merged 13 commits into from
Mar 11, 2016
Merged

2.0.0-alpha.3 #102

merged 13 commits into from
Mar 11, 2016

Conversation

remojansen
Copy link
Member

Description

This PR implements the 2.0.0-alpha.3 milestone
The PR also implements #86 but there is a issue with the build that needs to be solved.

Related Issue

#100
#98
#93
#92
#91
#101
#86
#87
#104
#103

Motivation and Context

Implements 2.0.0-alpha.3 as planned by the roadmap.

How Has This Been Tested?

Unit tests have been added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the type definitions.
  • I have updated the type definitions accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Jameskmonger
Copy link
Member

The builds all failed on build-type-definitions. Maybe the build needs to be retriggered @remojansen

@remojansen
Copy link
Member Author

Hi @Jameskmonger thanks for taking a look. I will do a commit tonight to try to fix this issue but I have another issue. I need to use the ES6 Proxy class here. I have created a SO question because I've not been able to fix it.

I'm also going to update the type definitions to fix #101

@remojansen remojansen mentioned this pull request Mar 10, 2016
@remojansen
Copy link
Member Author

2.0.0-alpha.3 landed 🚀 master 🎉

@remojansen remojansen closed this Mar 11, 2016
@remojansen remojansen reopened this Mar 11, 2016
remojansen added a commit that referenced this pull request Mar 11, 2016
@remojansen remojansen merged commit 105d337 into inversify:master Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants