Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix injecting a property with .then results in undefined (#1570) #1571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brahms116
Copy link

@brahms116 brahms116 commented May 30, 2024

Description

Used instance of Promise instead.

Struggled and unsure with the approached used to mock the promise stub in the modified test. Welcome for any feedback and ideas

Related Issue

#1570

Motivation and Context

Its a bug which was found when used in conjunction with typemoq, their mock objects were returning undefined when rebinding to them.

How Has This Been Tested?

Added relevant test to demonstrate the bug

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant