Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update get_all_named_tagged.md #346

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Conversation

Offirmo
Copy link
Contributor

@Offirmo Offirmo commented Aug 23, 2016

Minor doc update.

Just tested, typing is incorrect.
@mention-bot
Copy link

@Offirmo, thanks for your PR! By analyzing the annotation information on this pull request, we identified @remojansen to be a potential reviewer

@Offirmo Offirmo changed the title Update get_all_named_tagged.md Doc: Update get_all_named_tagged.md Aug 23, 2016
@lholznagel
Copy link
Contributor

I hink the [] needs to stay there:
let weapons = kernel.getAll<Weapon[]>("Weapon"); // returns Weapon[]

@Offirmo
Copy link
Contributor Author

Offirmo commented Aug 23, 2016

@lholznagel I tested it for real. Using [] cause a typescript failure claiming a return type of Weapon[][]. Not using [] works as expected.

It also makes sense. The [] is redundant and adds nothing.

@lholznagel
Copy link
Contributor

Oh okay, thanks for trying :)

@remojansen
Copy link
Member

Thanks for this as well :)

@remojansen remojansen merged commit 467afb5 into inversify:master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants