feat(globe_cli): Show build-log hint when deployment fails #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
codekeyz
changed the title
|
Could we highlight the command similar to 
|
|
codekeyz
changed the title
codekeyz
changed the title
|
@lesnitsky subtle reminder: this is still pending approval. |
lesnitsky
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: https://github.com/invertase/dart_globe/issues/104
This PR shows
globe build-loghint when deployment fails.➜ shelf git:(feat/show-build-logs-hint) ✗ dart run ../../packages/globe_cli/bin/globe.dart deploy ✓ Deploying to codekeyz/zomato (2.9s) ✓ Deployment has been queued 🔍 View deployment: https://globe.dev/codekeyz/zomato/deployments/b7dd77ab-7ee6-4eb2-86cc-a7343704d70e ✓ Queued (7.0s) ✗ Deployment failed (43.7s) Use globe build-logs --deployment="b7dd77ab-7ee6-4eb2-86cc-a7343704d70e" to view the build logsType of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore