Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error message when {#function:inline} macros are used. #62

Closed
NQNStudios opened this issue Dec 28, 2017 · 5 comments
Closed

Add an error message when {#function:inline} macros are used. #62

NQNStudios opened this issue Dec 28, 2017 · 5 comments
Assignees

Comments

@NQNStudios
Copy link
Collaborator

Every time I go to call a function and embed the output in a section, I forget whether or not I'm supposed to declare the macro with :inline or not. A specific error message would be nice, because currently what happens if you do the wrong thing (:inline), is you get targetFunction is undefined, which is confusing when you know you've defined the function.

@invicticide
Copy link
Owner

That error message is obviously nonsense, so I'll look into that. But the broader issue here seems to be that :inline is an unclear name... I wonder if that tag should be called something different?

@invicticide invicticide self-assigned this Dec 31, 2017
@NQNStudios
Copy link
Collaborator Author

Yeah, to be honest I thought I had it straight in my head and I still don't. The keyword makes the concept fuzzier in my head which makes it hard to think of a better keyword.

@NQNStudios
Copy link
Collaborator Author

To be clear, inline only applies to macros in link destinations and means the link itself transforms, right? Even now I'm not confident off the top of my head.

@invicticide
Copy link
Owner

Yeah, :inline is what you add to a link destination to say "replace the link with the expanded destination content when clicked". It has no meaning in any non-link context.

@NQNStudios
Copy link
Collaborator Author

Maybe it should just be :replace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants