Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totals are different in overdue invoices list view vs. edit/detailed view (rounding error) #1453

Closed
MagicFab opened this issue Apr 26, 2017 · 12 comments

Comments

@MagicFab
Copy link

MagicFab commented Apr 26, 2017

I am attaching two examples.

For invoice 484 the total is 140$ before taxes, total should be $160.97 once both taxes are added GST (5%): $7.00, QST (9.975%): $13.97. On the list view the total is correct, on the detailed view it indicated one cent difference ($160.96).

For invoice 479 the total is 1140$ before taxes, total should be $1310.72 once both taxes are added GST (5%): GST (5%): $57.00 QST (9.975%): $113.72. On the list view the total is correct, on the detailed view it indicated one cent difference ($1310.72).

I haven't checked if this also happens for regular (not overdue / already paid) invoices as there wasn't a total displayed at the moment I created them (apparently now possible through custom fields).

@MagicFab
Copy link
Author

0484-full-view
0479-list-view
0484-list-view
0479-full-view

@hillelcoren
Copy link
Member

hillelcoren commented Apr 26, 2017

It looks like a rounding problem, we'll try to include a fix in our next major release.

@MagicFab
Copy link
Author

MagicFab commented Apr 26, 2017

I forgot to mention, I double checked calculations with Revenue Canada's online tool, the example is for a business based in Quebec (using the corresponding tax %).

@MagicFab MagicFab changed the title Totals are different in overdue invoices list view vs. edit/detailed view. Totals are different in overdue invoices list view vs. edit/detailed view (rounding error) Apr 26, 2017
@hillelcoren
Copy link
Member

What tax rates are you using?

Also, if you don't use the line item taxes you can disable them on /settings/tax_rates

@MagicFab
Copy link
Author

MagicFab commented Apr 28, 2017

What tax rates are you using?

As I indicated initially, Quebec (provincial) sales tax (QST) is 9.975%. Government (federal) sales tax (GST) is 5%. In each example in my initial report I indicated corresponding amounts.

Also, if you don't use the line item taxes you can disable them on /settings/tax_rates

Sometimes taxes don't apply so I need some flexibility to either calculate globally or per-item, that's why I have this setup.

@hillelcoren
Copy link
Member

Thanks, I was referencing the screenshots

hillelcoren added a commit that referenced this issue Apr 29, 2017
hillelcoren added a commit that referenced this issue Apr 29, 2017
@MagicFab
Copy link
Author

MagicFab commented May 2, 2017

This now looks closed, is it possible to indicate an approximate time to release this and similar fixes to invoiceninja.com? RIght now I am delaying entering new invoices.

@hillelcoren
Copy link
Member

Ballpark time frame is two weeks.

@RCcola1987
Copy link

This is still not fixed and the PDF rounding error is still present. This is ridiculous that an error such as this is and was allowed to exist for so long. This is a BILLING system and accurate dollar amounts are the most important function. We are still dealing with customers getting bills that the PDF is off by 1 to 5 cents US. This is pathetic. This cannot wait until you all get around to your "next release" This is a critical bug that makes the software UNUSABLE and makes businesses that use it look like a bunch of fools to their customers. PATCH YOUR SHIT!.

@turbo124
Copy link
Member

@RCcola1987 we won't tolerate these types of comments, you'll need to be civil or you'll be removed from participating in any discussion on our repositories.

@cidapple
Copy link

cidapple commented Jul 8, 2022

@MagicFab @RCcola1987 @turbo124 i'm also from Quebec, i was on the verge of buying the entreprise version but i found this tread regarding the taxation. That get me wondering about the support invoce ninja provide to their customer. is the issue fixed?

@turbo124
Copy link
Member

turbo124 commented Jul 8, 2022

@cidapple I believe the issue with Quebec is that they use compounding taxes which is not supported in Invoice Ninja yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants