Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not build Docker images on PR #1933

Closed
wants to merge 11 commits into from
Closed

Do not build Docker images on PR #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f6b2a62
(ci) do not run docker image build workflow on PRs
ebr Dec 11, 2022
8d22f6d
(ci) run cloud docker image build on all tags
ebr Dec 11, 2022
9df2ae7
(ci) cancel redundant in-progress workflows for cloud docker build
ebr Dec 11, 2022
c3a1c8c
(ci) generally cancel redundant workflows to free up runners and spee…
ebr Dec 11, 2022
9041af1
(ci) remove conda test workflow
ebr Dec 11, 2022
1c7e651
(ci) revert to only build 'v*' tags because this is consistent with t…
ebr Dec 11, 2022
1f732d8
Merge branch 'main' into no-docker-build-on-pr
ebr Dec 12, 2022
017ef56
Merge branch 'main' into no-docker-build-on-pr
lstein Dec 13, 2022
1ac7fc6
Merge branch 'main' into no-docker-build-on-pr
lstein Dec 13, 2022
6e41f3a
add github.run_id to group to prevent cancelling main branch workflows
lstein Dec 13, 2022
82b2e96
add github.run_id to group to prevent cancelling main branch workflow…
lstein Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/build-cloud-img.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ on:
- main
tags:
- v*
# we will NOT push the image on pull requests, only test buildability.
pull_request:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read
Expand Down Expand Up @@ -66,9 +66,7 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

# do not login to container registry on PRs
- if: github.event_name != 'pull_request'
name: Docker login
- name: Docker login
uses: docker/login-action@v2
with:
registry: ghcr.io
Expand All @@ -82,6 +80,7 @@ jobs:
file: docker-build/Dockerfile.cloud
platforms: Linux/${{ matrix.arch }}
# do not push the image on PRs
# yes, we do not run this on PRs, but this is an additional safety net
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
4 changes: 4 additions & 0 deletions .github/workflows/build-container.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
branches:
- 'main'

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
docker:
strategy:
Expand Down