New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hover tooltips for Curve and Path types #1004

Merged
merged 2 commits into from Dec 8, 2016

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Dec 7, 2016

Currently dimensions that shouldn't be are appearing in the hover tooltips. Additionally on CurvePlot the NdOverlay dimension information isn't supplied at all. I've also made various fixes to make color and alpha option work correctly in batched mode.

@jbednar

This comment has been minimized.

Member

jbednar commented Dec 7, 2016

Looks good to me, and would be very welcome!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 7, 2016

There is a real bokeh notebook test failure because the previous data included wrong hover label. Will have to rebuild. I've also added various unit tests to check the correct hover information is set.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 8, 2016

Looks good to me too and the tests have passed. Ready to merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 8, 2016

Yep, go ahead.

@jbednar jbednar merged commit ceaa6d4 into master Dec 8, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 75.993%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the hover_fixes branch Dec 8, 2016

@philippjfr philippjfr added this to the v1.7.0 milestone Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment