Handle updating of bokeh legends #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
|
Going ahead and merging this, it's all changes in the plotting code which are hard to review anyway and I also want to ensure that this is tested for as long as possible before a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous legends were completely static in the bokeh backend, i.e. in a HoloMap it would display all legend items for all frames at once and in a DynamicMap they would simply not update. Additionally this PR fixes a bug where the addition of an annotation on a plot would cause a legend to appear.
Also includes various fixes for dynamically creating and reassigning plot instances to ensure that a) the cyclic index is consistent and that b) dynamically created plot instances are updated appropriately despite not being assigned the correct stream mappings.