Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on matplotlib, nbformat and pyparsing in ipython #529

Merged
merged 3 commits into from
Mar 23, 2016

Conversation

philippjfr
Copy link
Member

Addresses issues mentioned in #528 partially by removing all hard dependencies on notebook and matplotlib in the ipython module. This ensures holoviews can be imported in IPython even without matplotlib and the notebook.

holoviews.archive = notebook_archive
except ImportError:
pass

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we'll want to add some # noqa lines here for pyflakes...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, the nbformat lines will need it.

@jlstevens
Copy link
Contributor

Looks good and does what I expect. We only need jinja2 if widgets are requested and a conditional import of archive makes sense in case pyparsing is missing.

@philippjfr
Copy link
Member Author

We only need jinja2 if widgets are requested

Also used to display the notebook_extension output, but again that's only needed when working in the notebook anyway.

conditional import of archive makes sense in case pyparsing is missing.

Archive only requires nbformat. It's the parser that requires pyparsing which was already mostly working except that although the magics were wrapping the import in a try except the __init__.py was not.

@jbednar
Copy link
Member

jbednar commented Mar 2, 2016

Does this address the issues that Ilan found when he made conda packages for the main channel, for python3? Hopefully those extra dependencies that he found would no longer be needed?

@philippjfr
Copy link
Member Author

Yes it does, although we should still add notebook as a dependency to our conda package.

@jlstevens
Copy link
Contributor

Yes, I was confusing the use of pyparsing for the magics with nbformat for archive. The conditional import still makes sense though...

@philippjfr
Copy link
Member Author

Ready to merge once the tests pass.

@jlstevens
Copy link
Contributor

Ok the tests are passing so I'll merge it now.

@jlstevens jlstevens merged commit 757ac50 into master Mar 23, 2016
@philippjfr philippjfr deleted the fix_requirements branch April 1, 2016 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants