Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resetValues should not set the value to 0 #79

Closed
klein0r opened this issue Jul 20, 2022 · 3 comments
Closed

resetValues should not set the value to 0 #79

klein0r opened this issue Jul 20, 2022 · 3 comments
Labels

Comments

@klein0r
Copy link

klein0r commented Jul 20, 2022

When resetting states, there are better ways to reset the value

  • use deleteState to remove the state or
  • use the state.q flag to inform other adapters that this is not a "valid value"

See iobroker-community-adapters/ioBroker.statistics#128

@xXBJXx
Copy link
Contributor

xXBJXx commented Jul 23, 2022

I have now implemented it so that when the gas station is closed, the old value from the ioBroker remains and the state quality is set to ( 0x40 ⇒ Substitute value from device ). The same happens if for some reason no price is available at the gas station.
My PR here still needs to be merged for this, of course. 😃

@stale
Copy link

stale bot commented Oct 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix label Oct 29, 2022
@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically closed because of inactivity. Please open a new issue if still relevant and make sure to include all relevant details, logs and reproduction steps. Thank you for your contributions.
Dieses Problem wurde aufgrund von Inaktivität automatisch geschlossen. Bitte öffnet ein neues Issue, falls dies noch relevant ist und stellt sicher das alle relevanten Details, Logs und Reproduktionsschritte enthalten sind. Vielen Dank für Eure Unterstützung.

@stale stale bot closed this as completed Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants